Jump to content


Combobox drop down width in Edit Gadgets Mode


  • Please log in to reply
21 replies to this topic

#1 dwillis

dwillis

    Developer

  • Members
  • PipPipPip
  • 59 posts
  • LocationEdinburgh
  • Country: flag of United Kingdom United Kingdom


Posted 25 October 2011 - 09:21 PM

I've been having a fiddle with the GCS gui and noticed that when in Edit Gadgets Mode, the combo box drop down for narrow gadgets (vertical bargraphs) is unusably narrow:

Attached File  GCS_Narrow_Combo.png   4.79K   24 downloads

Would it be better to look something like this:

Attached File  GCS_Narrow_Combo_Better.png   13.11K   22 downloads

This is currently a dirty hack; if anyone thinks this is worth fixing, I'll look at doing it properly...

David

#2 peabody124

peabody124

    Crash Dummy

  • Administrators
  • 4110 posts
  • LocationHouston, TX
  • Country: flag of United States United States


Posted 25 October 2011 - 09:41 PM

Yeah that looks much better if you can pull it off.

#3 Edouard

Edouard

    GCS Developer

  • Members
  • PipPipPip
  • 716 posts
  • LocationParis
  • Country: flag of France France


Posted 26 October 2011 - 06:38 AM

Yes, careful though: the dropdown behaviour is a bit different on every platform in that respect, so be sure to tell at least on PC & Linux - either peabody124 or myself can do the Mac tests if you wish

#4 naiiawah

naiiawah

    Core Developer

  • Members
  • PipPipPip
  • 309 posts
  • LocationNorthwest USA
  • Country: flag of United States United States


Posted 26 October 2011 - 06:43 AM

I can test on Linux (and Mac too).

#5 dwillis

dwillis

    Developer

  • Members
  • PipPipPip
  • 59 posts
  • LocationEdinburgh
  • Country: flag of United Kingdom United Kingdom


Posted 26 October 2011 - 08:37 AM

I've confirmed that the existing behaviour is the same on Windows 7 and Linux. Having trawled through the Qt style code, it would appear that the current functionality is common to at least Windows and Linux. I'm working on getting my MacBook upgraded to Snow Leopard so hopefully I'll be able to test on that too... Do we support right to left languages? Is that something I should check too?

#6 dankers

dankers

    Janitor

  • Administrators
  • 5124 posts
  • Country: flag of Australia Australia


Posted 26 October 2011 - 09:04 AM

So far we have no translations of the GCS, I think left to right languages will be way down on the list, so for me at least, don't worry about it.

#7 dwillis

dwillis

    Developer

  • Members
  • PipPipPip
  • 59 posts
  • LocationEdinburgh
  • Country: flag of United Kingdom United Kingdom


Posted 26 October 2011 - 06:47 PM

Could someone check the current behaviour on a Mac? I've had a look at the code for QMacStyle and it appears to explicitly deal with the combo box drop down. None of the other styles seem to do this: they all use the default behaviour in QCommonStyle.

#8 peabody124

peabody124

    Crash Dummy

  • Administrators
  • 4110 posts
  • LocationHouston, TX
  • Country: flag of United States United States


Posted 26 October 2011 - 10:13 PM

Attached File  Screen Shot 2011-10-26 at 5.12.15 PM.png   323.02K   19 downloads

Mac already works

#9 dwillis

dwillis

    Developer

  • Members
  • PipPipPip
  • 59 posts
  • LocationEdinburgh
  • Country: flag of United Kingdom United Kingdom


Posted 26 October 2011 - 10:24 PM

Excellent, thanks for that. I'll make sure I don't break that... Incidentally, should I submit an issue in Jira for this?

#10 naiiawah

naiiawah

    Core Developer

  • Members
  • PipPipPip
  • 309 posts
  • LocationNorthwest USA
  • Country: flag of United States United States


Posted 27 October 2011 - 02:15 AM

View Postdankers, on 26 October 2011 - 09:04 AM, said:

So far we have no translations of the GCS, I think left to right languages will be way down on the list, so for me at least, don't worry about it.
Does English reverse like water in a drain down under?  Hmmm, must be one of those south of the equator things. ;) ;) ;)

#11 dankers

dankers

    Janitor

  • Administrators
  • 5124 posts
  • Country: flag of Australia Australia


Posted 27 October 2011 - 09:11 AM

View Postnaiiawah, on 27 October 2011 - 02:15 AM, said:

Does English reverse like water in a drain down under?  Hmmm, must be one of those south of the equator things. ;) ;) ;)

˙ʇǝuɐןd ǝɥʇ ɟo doʇ ǝɥʇ ʇɐ sʎnb noʎ ɹoɟ dn ʎɐʍ ɹǝɥʇo ǝɥʇ ǝʇıɹʍ oʇ buıʌɐɥ uo ʇı ǝɯɐןq ı

#12 joecnc2006

joecnc2006

    Key Member

  • Members
  • PipPipPip
  • 447 posts
  • Country: flag of United States United States


Posted 28 October 2011 - 12:14 AM

View Postdankers, on 27 October 2011 - 09:11 AM, said:


˙ʇǝuɐןd ǝɥʇ ɟo doʇ ǝɥʇ ʇɐ sʎnb noʎ ɹoɟ dn ʎɐʍ ɹǝɥʇo ǝɥʇ ǝʇıɹʍ oʇ buıʌɐɥ uo ʇı ǝɯɐןq ı

ı ǝɯɐןq ʇı uo buıʌɐɥ oʇ ǝʇıɹʍ ǝɥʇ ɹǝɥʇo ʎɐʍ dn ɹoɟ noʎ sʎnb ʇɐ ǝɥʇ doʇ ɟo ǝɥʇ ʇǝuɐןd˙
Thanks,
Joe
www.joescnc.com

#13 naiiawah

naiiawah

    Core Developer

  • Members
  • PipPipPip
  • 309 posts
  • LocationNorthwest USA
  • Country: flag of United States United States


Posted 28 October 2011 - 12:55 AM

View Postdankers, on 27 October 2011 - 09:11 AM, said:


˙ʇǝuɐןd ǝɥʇ ɟo doʇ ǝɥʇ ʇɐ sʎnb noʎ ɹoɟ dn ʎɐʍ ɹǝɥʇo ǝɥʇ ǝʇıɹʍ oʇ buıʌɐɥ uo ʇı ǝɯɐןq ı
ROFLMAO!!!   :lol:

#14 dwillis

dwillis

    Developer

  • Members
  • PipPipPip
  • 59 posts
  • LocationEdinburgh
  • Country: flag of United Kingdom United Kingdom


Posted 03 November 2011 - 02:15 PM

Right, I'm nearly at a solution I like so how do I go about submitting it?

#15 Berkely

Berkely

    Core Team

  • Core Team
  • PipPipPip
  • 615 posts
  • Country: flag of Flemish Belgium Flemish Belgium


Posted 09 January 2012 - 09:41 AM

A small thing but does this also apply to the dropdown boxes of the mixer?

Posted Image

#16 dwillis

dwillis

    Developer

  • Members
  • PipPipPip
  • 59 posts
  • LocationEdinburgh
  • Country: flag of United Kingdom United Kingdom


Posted 09 January 2012 - 12:18 PM

I'll have a look on my build. I think it should apply to all drop downs...

#17 dankers

dankers

    Janitor

  • Administrators
  • 5124 posts
  • Country: flag of Australia Australia


Posted 09 January 2012 - 03:04 PM

So basically, this fix never got merged? If that is the case, I am very sorry to have missed that, and I will work on getting it merged ASAP.

#18 dwillis

dwillis

    Developer

  • Members
  • PipPipPip
  • 59 posts
  • LocationEdinburgh
  • Country: flag of United Kingdom United Kingdom


Posted 09 January 2012 - 05:08 PM

I do know it made it as far as next some time ago.

#19 dankers

dankers

    Janitor

  • Administrators
  • 5124 posts
  • Country: flag of Australia Australia


Posted 09 January 2012 - 05:36 PM

OK, then it is now in master, great.

We have some USB issues to resolve then there should be a new release with quite a few fixes on the GCS side.

#20 Berkely

Berkely

    Core Team

  • Core Team
  • PipPipPip
  • 615 posts
  • Country: flag of Flemish Belgium Flemish Belgium


Posted 09 January 2012 - 07:36 PM

View Postdankers, on 09 January 2012 - 03:04 PM, said:

So basically, this fix never got merged? If that is the case, I am very sorry to have missed that, and I will work on getting it merged ASAP.

Well, the initial problem was solved for the analog & bar-graph dials, that was in next already. I just noticed today that the drop down boxes from the mixer were different. Probably that's a different item then.