21 replies to this topic

[dwillis]

I've been having a fiddle with the GCS gui and noticed that when in Edit Gadgets Mode, the combo box drop down for narrow gadgets (vertical bargraphs) is unusably narrow:

 GCS_Narrow_Combo.png   4.79K   24 downloads

Would it be better to look something like this:

 GCS_Narrow_Combo_Better.png   13.11K   22 downloads

This is currently a dirty hack; if anyone thinks this is worth fixing, I'll look at doing it properly...

David

[peabody124]

Yeah that looks much better if you can pull it off.

[Edouard]

Yes, careful though: the dropdown behaviour is a bit different on every platform in that respect, so be sure to tell at least on PC & Linux - either peabody124 or myself can do the Mac tests if you wish

[naiiawah]

I can test on Linux (and Mac too).

[dwillis]

I've confirmed that the existing behaviour is the same on Windows 7 and Linux. Having trawled through the Qt style code, it would appear that the current functionality is common to at least Windows and Linux. I'm working on getting my MacBook upgraded to Snow Leopard so hopefully I'll be able to test on that too... Do we support right to left languages? Is that something I should check too?

[dankers]

So far we have no translations of the GCS, I think left to right languages will be way down on the list, so for me at least, don't worry about it.

[dwillis]

Could someone check the current behaviour on a Mac? I've had a look at the code for QMacStyle and it appears to explicitly deal with the combo box drop down. None of the other styles seem to do this: they all use the default behaviour in QCommonStyle.

[peabody124]

 Screen Shot 2011-10-26 at 5.12.15 PM.png   323.02K   19 downloads

Mac already works

[dwillis]

Excellent, thanks for that. I'll make sure I don't break that... Incidentally, should I submit an issue in Jira for this?

[naiiawah]

dankers, on 26 October 2011 - 09:04 AM, said:

So far we have no translations of the GCS, I think left to right languages will be way down on the list, so for me at least, don't worry about it.

Does English reverse like water in a drain down under?  Hmmm, must be one of those south of the equator things.

[dankers]

naiiawah, on 27 October 2011 - 02:15 AM, said:

Does English reverse like water in a drain down under?  Hmmm, must be one of those south of the equator things.

˙ʇǝuɐןd ǝɥʇ ɟo doʇ ǝɥʇ ʇɐ sʎnb noʎ ɹoɟ dn ʎɐʍ ɹǝɥʇo ǝɥʇ ǝʇıɹʍ oʇ buıʌɐɥ uo ʇı ǝɯɐןq ı

[joecnc2006]

dankers, on 27 October 2011 - 09:11 AM, said:

˙ʇǝuɐןd ǝɥʇ ɟo doʇ ǝɥʇ ʇɐ sʎnb noʎ ɹoɟ dn ʎɐʍ ɹǝɥʇo ǝɥʇ ǝʇıɹʍ oʇ buıʌɐɥ uo ʇı ǝɯɐןq ı

ı ǝɯɐןq ʇı uo buıʌɐɥ oʇ ǝʇıɹʍ ǝɥʇ ɹǝɥʇo ʎɐʍ dn ɹoɟ noʎ sʎnb ʇɐ ǝɥʇ doʇ ɟo ǝɥʇ ʇǝuɐןd˙

[naiiawah]

dankers, on 27 October 2011 - 09:11 AM, said:

˙ʇǝuɐןd ǝɥʇ ɟo doʇ ǝɥʇ ʇɐ sʎnb noʎ ɹoɟ dn ʎɐʍ ɹǝɥʇo ǝɥʇ ǝʇıɹʍ oʇ buıʌɐɥ uo ʇı ǝɯɐןq ı

ROFLMAO!!!  

[dwillis]

Right, I'm nearly at a solution I like so how do I go about submitting it?

[Berkely]

A small thing but does this also apply to the dropdown boxes of the mixer?

[dwillis]

I'll have a look on my build. I think it should apply to all drop downs...

[dankers]

So basically, this fix never got merged? If that is the case, I am very sorry to have missed that, and I will work on getting it merged ASAP.

[dwillis]

I do know it made it as far as next some time ago.

[dankers]

OK, then it is now in master, great.

We have some USB issues to resolve then there should be a new release with quite a few fixes on the GCS side.

[Berkely]

dankers, on 09 January 2012 - 03:04 PM, said:

So basically, this fix never got merged? If that is the case, I am very sorry to have missed that, and I will work on getting it merged ASAP.

Well, the initial problem was solved for the analog & bar-graph dials, that was in next already. I just noticed today that the drop down boxes from the mixer were different. Probably that's a different item then.